Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ref on infallible_destructuring_match suggestion #9850

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Preserve ref on infallible_destructuring_match suggestion #9850

merged 1 commit into from
Nov 18, 2022

Conversation

pheki
Copy link
Contributor

@pheki pheki commented Nov 15, 2022

Fixes #7499

changelog: [infallible_destructuring_match]: Preserve ref on suggestion

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 15, 2022
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks for this.

Also, warm welcome to clippy!

@dswij
Copy link
Member

dswij commented Nov 18, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 18, 2022

📌 Commit 93ac0f5 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 18, 2022

⌛ Testing commit 93ac0f5 with merge dfe37f1...

@bors
Copy link
Collaborator

bors commented Nov 18, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing dfe37f1 to master...

@bors bors merged commit dfe37f1 into rust-lang:master Nov 18, 2022
@pheki
Copy link
Contributor Author

pheki commented Nov 20, 2022

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infallible_destructuring_match misses ref in suggested fix
4 participants