Fix manual_let_else produces a wrong suggestion with or-patterns #9966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
alex-semenyuk
force-pushed
the
manual_let_else_paren
branch
2 times, most recently
from
27f60f1
to
e940606
Compare
|
☔ The latest upstream changes (presumably #9943) made this pull request unmergeable. Please resolve the merge conflicts. |
xFrednet
approved these changes
Dec 1, 2022
alex-semenyuk
force-pushed
the
manual_let_else_paren
branch
from
e940606
to
05477ff
Compare
|
@xFrednet Rebased |
|
LGTM, thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9938
changelog: Sugg: [
manual_let_else]: Suggestions for or-patterns now include required brackets.#9966