Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cross contexts while building the suggestion for redundant_closure_call #9987

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Don't cross contexts while building the suggestion for redundant_closure_call #9987

merged 1 commit into from
Nov 30, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 29, 2022

fixes #9957

changelog: redundant_closure_call: Don't cross macro contexts while building the suggestion

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2022

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 29, 2022
flip1995
flip1995 reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think the dogfood error is a false positive? If so, I would be fine with just adding and expect attribute with an explanation. No need to fix that FP in this PR.

tests/ui/redundant_closure_call_fixable.stderr Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 30, 2022

📌 Commit e0eba9c has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 30, 2022

⌛ Testing commit e0eba9c with merge 87963f0...

@bors
Copy link
Collaborator

bors commented Nov 30, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 87963f0 to master...

@bors bors merged commit 87963f0 into rust-lang:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redundant_closure_call inside macro mangles code
4 participants
@Jarcho @rustbot @flip1995 @bors