Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document release tarballs with vendor directories filled. #258

Closed
andrewchambers opened this issue Sep 18, 2019 · 13 comments
Closed

Document release tarballs with vendor directories filled. #258

andrewchambers opened this issue Sep 18, 2019 · 13 comments

Comments

@andrewchambers
Copy link

It has come to my attention there doesn't seem to be a way to download rust release tarballs which have dependencies vendored and submodules cloned.

The stable link here: https://forge.rust-lang.org/infra/other-installation-methods.html gives a 404 error.

The github release tarballs don't have dependencies bundled.

@Mark-Simulacrum
Copy link
Member

I'm going to move this over to forge as per my note here we do actually publish these, we're just apparently not documenting it anywhere, and we should do that.

@Mark-Simulacrum Mark-Simulacrum transferred this issue from rust-lang/rust Sep 18, 2019
@andrewchambers
Copy link
Author

@Mark-Simulacrum ah, I see the link. I'm slightly concerned this ticket will just be ignored similar to other forge tickets on the same topic.

@andrewchambers
Copy link
Author

see #215

@andrewchambers
Copy link
Author

@Mark-Simulacrum Note the links you provided don't have vendor directories and submodules filled.

@Mark-Simulacrum
Copy link
Member

Hm, that looks false to me? Unpacking https://static.rust-lang.org/dist/2019-08-15/rustc-1.37.0-src.tar.xz I see a vendor directory with all the crates.io deps and a quick ls src/llvm-project implies that the submodule is there as well -- can you clarify what sources you were expecting to see?

@andrewchambers
Copy link
Author

Ah thank you, I tried a rust-src link not a rustc-src link. Slightly confusing, I imagined rust would be less specific than rustc.

@andrewchambers
Copy link
Author

andrewchambers commented Sep 19, 2019

@Mark-Simulacrum Note the tarball you linked is not in the manifests you linked, and there is not public index so nobody has any way to find that.

@Mark-Simulacrum
Copy link
Member

Yes, we don't include it in the manifests today -- I think that's probably "just a bug" -- we'd want to be careful to not add it as a rustup component if we do add it to manifests, though.

@XAMPPRocky
Copy link
Member

This looks like this functionality would be easy to the mdbook plugin, however I don't know what the expected content to put in "Other Installation Methods". Which tarballs of which toolchains should be shown? What do we say about what the intended purpose of them is?

@andrewchambers
Copy link
Author

andrewchambers commented Sep 19, 2019

Offline builds/Distributions/package maintainers/other

@XAMPPRocky
Copy link
Member

XAMPPRocky commented Sep 19, 2019

@andrewchambers Distributions & Package maintainers I believe are not in the manifest files.

@andrewchambers
Copy link
Author

Sorry, I misread your question.

@XAMPPRocky XAMPPRocky changed the title Please publish release tarballs with vendor directories filled. Document release tarballs with vendor directories filled. Jun 5, 2020
@ehuss
Copy link
Contributor

ehuss commented Oct 26, 2023

I'm not really clear what this issue is asking for. It looks like the links at https://forge.rust-lang.org/infra/other-installation-methods.html#source-code contain direct links to the source tarballs with all the vendoring and submodules. Since this is quite old, I'm going to assume that is now resolved.

@ehuss ehuss closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants