Fix off-by-one in toolstate breakage week start. #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be a timezone issue? |
|
I considered that. However, I'm pretty sure CI works off UTC. It's currently Aug 6 1pm UTC. It is Aug 6, very early in the morning my time. It looks like the javascript also uses UTC. |
|
@ehuss Hey, sorry that this PR now has merge conflicts. Would you be able to check if this is still present? And we can then merge this or another PR. |
ehuss
force-pushed
the
beta-breakage-date
branch
from
ce80fdf
to
502ed74
Compare
|
Yea, I rebased with the latest. Also, the new dates seem to be backwards. It shows "to → from", which seems the opposite of how I would read a date range. |
|
@ehuss Thank you I just made a PR to fix that. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC, based on the rules in
checktools.sh, Tue before release is 41, Wed is 0. The check is-ge 35. 35 is the Wednesday of the prior week. The current forge site says "no tools breakage starts Aug 6", which is Tuesday. But a tool broke today, so I believe it starts tomorrow.