Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying S-waiting-on-team procedure #68

Merged
merged 1 commit into from
Jun 6, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pr-triage-procedure.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,19 @@ If the **review is incomplete**:

## [S-waiting-on-team PRs]

PRs active within the last 4 days need to be processed. These can be found by looking at
the "updated X days ago" on GitHub's PR list.
PRs active within the last 4 days and inactive for greater than 2 weeks need to be processed.
These can be found by looking at the "updated X days ago" on GitHub's PR list.

First, ensure that the status tag matches the current state of the PR. Change the tag if necessary,
and apply the procedure for the new tag now. Verify that there is a T- tag
for all PRs that remain in this category.

If the PR has been inactive for greater than 2 weeks, ping the team lead on IRC and on GitHub,
noting that you've pinged on IRC.

If there has been recent activity, the team might have taken some action meaning the state has
changed but the label has not yet been updated. Therefore, we also check the most recent ones.

[S-waiting-on-team PRs]: https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+label%3AS-waiting-on-team+sort%3Aupdated-desc

## [S-waiting-on-bors PRs]
Expand Down