Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert posix scripts to bash #102

Closed
wants to merge 1 commit into from

Conversation

Daniel-Worrall
Copy link

@Daniel-Worrall Daniel-Worrall commented May 5, 2020

Addresses rust-lang/rust#31036

E: Force was because I saw the file had CRLF, not LF, so fixed.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Sorry but I don't have time to review this, I'd recommend working with folks from rust-lang/rust to review this.

@Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum for now, though it's unlikely that we'll review this before the main rustc PR has a decision made it on it

@Daniel-Worrall
Copy link
Author

Closing after it was assessed by the infra team. rust-lang/rust#71932 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants