Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: Update tr(1) usage for Solaris compat #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inferiorhumanorgans
Copy link

@inferiorhumanorgans inferiorhumanorgans commented Aug 1, 2023

Seems like wrapping the character range with square brackets is safe for both BSD and GNU tr(1). Without the brackets Solaris' tr(1) chokes and treats - as a literal and not a range despite the man page suggesting otherwise. The SUSv2 (/usr/xpg4/bin/tr) and SUSv3 (/usr/xpg6/bin/tr) versions likewise don't function as intended without the brackets.

With these changes in place the installer works on Solaris 11.4.

On Solaris:

$ pkg list entire
NAME (PUBLISHER)                                  VERSION                    IFO
entire                                            11.4-11.4.0.0.1.15.0       i--

$ echo 'foobar-1' | /usr/bin/tr 'a-z-' 'A-Z_'
foobAr_1

$ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_'
FOOBAR_1

On macOS 10.14:

$ echo 'foobar-1' | /usr/bin/tr 'a-z-' 'A-Z_'
FOOBAR_1

$ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_'
FOOBAR_1

$ gtr --version
tr (GNU coreutils) 9.3
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.

Written by Jim Meyering.

$ echo 'foobar-1' | /opt/local/bin/gtr 'a-z-' 'A-Z_'
FOOBAR_1

$ echo 'foobar-1' | /opt/local/bin/gtr '[a-z]-' '[A-Z]_'
FOOBAR_1

Seems like wrapping the character range with square brackets is safe
for both BSD and GNU tr.  Without the brackets Solaris' tr(1) chokes
and treats - as a literal and not a range despite the man page
suggesting otherwise.

On Solaris:
$ echo 'foobar-1' | /usr/bin/tr 'a-z-' 'A-Z_'
foobAr_1

$ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_'
FOOBAR_1

On macOS 10.14:
$ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_'
FOOBAR_1

$ echo 'foobar-1' | /usr/bin/tr '[a-z]-' '[A-Z]_'
FOOBAR_1

$ gtr --version
tr (GNU coreutils) 9.3
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Jim Meyering.

$ echo 'foobar-1' | /opt/local/bin/gtr '[a-z]-' '[A-Z]_'
FOOBAR_1

$ echo 'foobar-1' | /opt/local/bin/gtr '[a-z]-' '[A-Z]_'
FOOBAR_1
@rustbot
Copy link

rustbot commented Aug 1, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants