Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --bindir and --sysconfdir support #59

Merged
merged 2 commits into from
May 10, 2017
Merged

add --bindir and --sysconfdir support #59

merged 2 commits into from
May 10, 2017

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Apr 28, 2017

No description provided.

@Keruspe
add --bindir support
3544aed 
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Keruspe
Copy link
Contributor Author

Keruspe commented Apr 28, 2017 •
edited

This is the first step for adding bindir support to rustbuild.
A concrete example of why it is needed:
On exherbo we install everything that is arch-specific in /usr/<arch>/{bin,lib,libexec} and everything arch-independant to /usr/share and friends.
With the current setup, mostly everything would install fine with rustbuild if we set the prefix to /usr/<arch> for example but some things like cargo's shell completions are wrongly installed inside /usr/<arch>/share.
If this gets accepted I'll send a followup pull request for doing the same with sysconfdir (same problem, bash completion gets installed to /usr/<arch>/etc. (Of course I can add that directly to this pull request, if you want)

@Keruspe
add --sysconfdir support
524a564 
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Keruspe Keruspe changed the title add --bindir support add --bindir and --sysconfdir support Apr 28, 2017
@Keruspe
Copy link
Contributor Author

Keruspe commented Apr 28, 2017

I figure it's just as easy to review both at the same time so I pushed the sysconfdir stuff too.

@Keruspe Keruspe mentioned this pull request Apr 30, 2017
Closed
@Keruspe Keruspe mentioned this pull request May 9, 2017
Merged
@alexcrichton alexcrichton merged commit daff079 into rust-lang:master May 10, 2017
@alexcrichton
Copy link
Member

Thanks and sorry for the delay!

bors added a commit to rust-lang/rust that referenced this pull request May 16, 2017
@bors
Auto merge of #41853 - Keruspe:install, r=alexcrichton
b28cf75 
rustbuild: add support for --bindir and --sysconfdir

This depends on rust-lang/rust-installer#59 and we'll need to udpate the rust-installer submodule once it gets merged for it to work

Fixes #41644
@cuviper cuviper mentioned this pull request May 19, 2017
Closed
@nbp nbp mentioned this pull request May 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Keruspe @alexcrichton