-
Notifications
You must be signed in to change notification settings - Fork 81
Output pane is too high in Chromium 43 #112
Comments
It shouldn't be covering the text field at all, really. The text editing widget can be resized so that the lower half of it or whatever isn't covering it. It makes it very hard to deal with compiler errors when the errors themselves sometimes obscure the very code they're reporting! |
There are a few Chromium bugs reported on 43 about flexbox, but I can't easily see whether they are the same issue. I started minimizing a test case to submit to the Chromium project, here's a work in progress: https://gist.github.com/lastorset/b2dd56310745cd1d10f6 I have to pause now, but the remaining steps would be to make it deterministic, that is independent of window size, and easy to decide whether it passes. (It should use Ahem, a font with predictable size, and it should use non-relative, non-viewport dependent sizes. It should come with instructions like "There should be no red" or "There should be green".) We can submit a bug report even without this, of course, but we risk the project not seeing the problem. |
Finished minimizing it now. I think this is either https://code.google.com/p/chromium/issues/detail?id=464210 or because it sort of looks like Chromium doesn't consider the flexboxes to have definite size. If it's the latter it was fixed on 5 August, but I don't believe I have a Chromium to test it on now. If someone runs Windows they can try Chrome Canary. Otherwise I might try building Chromium from source tomorrow. If it's not fixed on master, we should submit a bug report with a note that it may be a dupe of 464210. EDIT: …and that this is a regression in Chromium 43…which actually makes it likely that this is not 464210, since that's been present since Chromium 21. |
I now think this is actually a bug in Firefox instead. The spec changed, so that now flex items only have a definite size if they have a definite flex basis. In our case, It might seem that Firefox is doing the right thing, or at least the most lenient thing, but it's against the spec and will change in the future. The simple fix is to give
I've modified the pass condition of the test case and attached it in Bugzilla. |
(By the way, if anybody should be wondering: this does fail on Wednesday's Chromium.) |
Give <main> a definite flex basis (fixes #112)
In Chromium 43, the output pane is too high, covering almost the entire text field.
![](https://camo.githubusercontent.com/46467e76507d3a67d9cdc03a6bf46a62e26045ae4d62c4ffecfba6af797d5c82/687474703a2f2f692e696d6775722e636f6d2f4b6a724e3854392e706e67)
This doesn't occur with Chromium 42 or Firefox, so this might be a regression in Chromium 43.
The text was updated successfully, but these errors were encountered: