Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vim's Syntax highlinging #326

Open
mendess opened this issue May 21, 2019 · 11 comments
Open

Update Vim's Syntax highlinging #326

mendess opened this issue May 21, 2019 · 11 comments

Comments

@mendess
Copy link

mendess commented May 21, 2019

Update the official vim syntax highlighting. It's showing crate as an invalid keyword sometimes.

I tried opening a PR on there but they ask that the syntax's maintainer do it.

@pengshao
Copy link

pengshao commented Aug 9, 2019

+1 on this, i had to manually change it

@XVilka
Copy link

XVilka commented Oct 15, 2019

Would be nice to upstream it, indeed.

@blueyed
Copy link

blueyed commented Oct 15, 2019

According to vim/vim#5049 (comment) a new update should be sent to Bram for inclusion.

@chrisbra
Copy link

chrisbra commented Dec 4, 2019

Note, there will be a new official Vim release pretty soon, so updating the runtime files now would be a good idea.

@tesuji
Copy link

tesuji commented May 11, 2020

+1 for this. What is blocking this from happening?

@tesuji
Copy link

tesuji commented May 11, 2020

cc @da-x

@adrian5
Copy link

adrian5 commented May 17, 2020

The rust.vim that ships with (neo)vim was last edited 2017. Would be nice if we could offer users a more recent default, instead of expecting them to chase it down manually.

Btw, the current file still reads Last change: Feb 24, 2016. I would suggest to update that, because wrong information is worse than missing information.

@WhyNotHugo
Copy link

For those using neovim, I'd recommend looking at tree-sitter for handling highlighting. It's much lighter and done more efficiently.

There's also no incompatibility between it and this plugin, it'll just take over highlighting.

@XVilka
Copy link

XVilka commented Mar 3, 2021

While I perfectly understand the negative attitude towards JS, it's not a complete JS set, just a subset of it. Also, there was a proposal to remove the need for it, see the discussion at tree-sitter/tree-sitter#465
In general, it's much faster and more reliable than regex-based parsing and syntax highlight. Especially on more complex grammars of which Rust is a good example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants