Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the get_positional_arg_spans to take into count the format types #100891

Open
vincenzopalazzo opened this issue Aug 22, 2022 · 3 comments
Open

Improve the get_positional_arg_spans to take into count the format types #100891

vincenzopalazzo opened this issue Aug 22, 2022 · 3 comments
Assignees
@vincenzopalazzo
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@vincenzopalazzo
Copy link
Member

vincenzopalazzo commented Aug 22, 2022 •
edited by rustbot

As discussed in #100826 (comment)

Suggested-by @TaKO8Ki
@vincenzopalazzo
Copy link
Member Author

@rustbot claim

@vincenzopalazzo
Copy link
Member Author

@rustbot label +T-compiler +A-diagnostics

@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2022
@vincenzopalazzo vincenzopalazzo mentioned this issue Aug 22, 2022
Merged
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Aug 23, 2022 •
edited

I think the following are where we need to fix:

rust/compiler/rustc_builtin_macros/src/format.rs

Line 445 in 015a824

has_precision || has_width,

rust/compiler/rustc_builtin_macros/src/format.rs

Line 456 in 015a824

has_precision || has_width,

@TaKO8Ki TaKO8Ki mentioned this issue Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vincenzopalazzo @TaKO8Ki @rustbot