Rename glue and refactor push_tree
#106481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Comment on lines
+713
to
+716
| /// Checks if the current token is a multiple-character token (or glued like `==`, `<=`, `...`) | ||
| /// and returns the corresponding `TokenKind` if it is. | ||
| /// | ||
| /// if the current tokens is already complete, returns `None`. |
There was a problem hiding this comment.
I don't think this comment explains what this method is doing properly.
What this is doing is checking if the current token can be combined with the joint token to turn into a multiple-character token.
| /// and returns the corresponding `TokenKind` if it is. | ||
| /// | ||
| /// if the current tokens is already complete, returns `None`. | ||
| pub fn check_is_multiple_char_token(&self, joint: &Token) -> Option<Token> { |
There was a problem hiding this comment.
I prefer the name glue. Adding a doc comment is fine, but the new name doesn't really explain that we're trying to combine self and joint into a new "glued"/merged/combined/joined token.
There was a problem hiding this comment.
Certainly it doesn't seem very practical. Thank you for your feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the glue function to check_is_multiple_char_token and added some comments.
And I think the
push_treefunction could only check the!Self::try_glue_to_lastcondition, so I refactored it.thanks