Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we seal FileExt, MetadataExt and OpenOptionsExt? #118816

Open
ho-229 opened this issue Dec 11, 2023 · 4 comments
Open

Should we seal FileExt, MetadataExt and OpenOptionsExt? #118816

ho-229 opened this issue Dec 11, 2023 · 4 comments
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ho-229
Copy link

ho-229 commented Dec 11, 2023

context #118795 (comment)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 11, 2023
@taiki-e
Copy link
Member

taiki-e commented Dec 11, 2023

See #81213 (comment) for previous discussions.

@ChrisDenton
Copy link
Contributor

ChrisDenton commented Dec 11, 2023 •
edited

In summary, the results of the 2021 crater run were that it's likely ok to seal:

  • FileTypeExt
  • MetadataExt
  • PermissionsExt

Sealing OpenOptionsExt and FileExt caused too many problems.

@ho-229
Copy link
Author

ho-229 commented Dec 11, 2023

thanks

@ho-229 ho-229 closed this as completed Dec 11, 2023
@ho-229
Copy link
Author

ho-229 commented Dec 12, 2023

Hello everyone

Some extension traits like std::os::windows::fs::MetadataExt which contains unstable method that can't implement by user without nightly feature. And I note tokio and async_fs don't implement these extension traits nowadays.

So I think we should reconsider this issue.

@ho-229 ho-229 reopened this Dec 12, 2023
@saethlin saethlin added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-discussion Category: Discussion or questions that doesn't represent real issues. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ChrisDenton @saethlin @taiki-e @rustbot @ho-229