-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump elided_lifetimes_in_associated_constant
to deny
#124211
base: master
Are you sure you want to change the base?
Bump elided_lifetimes_in_associated_constant
to deny
#124211
Conversation
@rfcbot fcp merge |
Team member @tmandry has proposed to merge this. The next step is review by the rest of the tagged team members: Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
Actually, I don't believe we should have this lint at all and should just use @rfcbot concern let's just use 'static |
I'd be happy continuing with our previous direction here, so But I'm also sympathetic to tyler's idea that it might be reasonable to decide to add an elision rule for this. I don't like an elision rule for |
|
@compiler-errors Does going straight to
Generally sympathetic, and from the notes we decided to do this before. At the same time, it is churn that feels unnecessary if we are going to turn around and allow all of the code again. Speaking of which: Did we ever look at how much churn there is in crater? While the decision of using @rfcbot resolve let's just use 'static |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Looking at the references to #115010 at the bottom of the issue, this lint has created a lot of churn already. This makes me think we should leave this PR nominated and discuss again at the next lang team meeting: Do we see a feasible alternative to going down this route? |
@tmandry I feel like I'm missing context here. I'm not sure, for example, what the current behavior is, etc. I'm sympathetic to defaulting to I can certainly imagine reasons to not want |
@rfcbot concern wait for FCP to default to 'static |
The FCP in question has been proposed here: #125190 |
It's been 5 versions since this was last bumped. Let's bump it up again.