Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'bors lint' for changing submodules #12463

Closed
brson opened this issue Feb 22, 2014 · 3 comments
Closed

Add a 'bors lint' for changing submodules #12463

brson opened this issue Feb 22, 2014 · 3 comments

Comments

@brson
Copy link
Contributor

brson commented Feb 22, 2014

It's very easy to accidentally revert submodule changes. Bors should remind us to be careful when changing submodules.

cc #12373
@japaric
Copy link
Member

japaric commented Oct 14, 2014

This sounds like a job for @rust-highfive

cc @nick29581

@nrc nrc mentioned this issue Oct 14, 2014
Closed
@nrc
Copy link
Member

nrc commented Oct 14, 2014

Yes, should be fairly easy to add. I filed rust-lang/highfive#7

@flaper87
Copy link
Contributor

This has been implemented in highfive: rust-lang/highfive#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flaper87 @brson @nrc @japaric