Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoanPath should not track Box at all #16118

Closed
zwarich opened this issue Jul 30, 2014 · 5 comments
Closed

LoanPath should not track Box at all #16118

zwarich opened this issue Jul 30, 2014 · 5 comments
Labels
A-typesystem Area: The type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@zwarich
Copy link

zwarich commented Jul 30, 2014

The changes in #16102 cause the borrow checker to track Box with decreased precision. They should be removed when LoanPath doesn't track Box values at all.
@zwarich
Copy link
Author

zwarich commented Jul 30, 2014

This will require a DerefMove trait or something like it.

@steveklabnik steveklabnik added the A-typesystem Area: The type system label Jan 27, 2015
@steveklabnik
Copy link
Member

@zwarich is this issue still relevant?

@zwarich
Copy link
Author

zwarich commented Jan 31, 2015

Yes. It will need to wait for after 1.0. It's also related to #14270.

@pnkfelix pnkfelix self-assigned this Mar 29, 2015
@steveklabnik steveklabnik added A-lang T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Nov 15, 2016
@steveklabnik
Copy link
Member

Triage: this issue is still relevant today, though I'm not sure keeping this issue open here is the right spot for it.

@Mark-Simulacrum Mark-Simulacrum added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jul 21, 2017
@Mark-Simulacrum
Copy link
Member

I think it makes sense to close this at this point -- we're not able to make movement here before DerefMove or the equivalent is implemented. This issue is also misleading, because while it says this is cleanup it's more of a feature expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-typesystem Area: The type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @pnkfelix @zwarich @Mark-Simulacrum