Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tidy should require an issue number in FIXMEs #19546

Closed
nrc opened this issue Dec 5, 2014 · 4 comments
Closed

make tidy should require an issue number in FIXMEs #19546

nrc opened this issue Dec 5, 2014 · 4 comments

Comments

@nrc
Copy link
Member

nrc commented Dec 5, 2014

We used to do this and it was annoying, but it is more annoying not to have it. Let's reinstate it!
@nrc nrc added the A-build label Dec 5, 2014
@nikomatsakis
Copy link
Contributor

cc me

@Gankra
Copy link
Contributor

Gankra commented Dec 5, 2014

There's a few FIXME's in libcollections that amount to "Future optimization/design work" that don't super make sense to have issues logged against them. I guess we could have a misc "make stuff better" bug.

@nrc
Copy link
Member Author

nrc commented Dec 16, 2014

We discussed this at the weekly meeting, and whilst we think we could do something better, requiring issue numbers when we haven't would be too much work and mean coming up with a lot of pointless issues. Reviewers should encourage issue numbers in FIXMEs, but we won't change make tidy for now.

@nrc nrc closed this as completed Dec 16, 2014
@pnkfelix
Copy link
Member

cc #3303 #11815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikomatsakis @pnkfelix @nrc @Gankra