Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libunicode regex consts should have the same form if possible #22699

Closed
mdinger opened this issue Feb 23, 2015 · 2 comments
Closed

libunicode regex consts should have the same form if possible #22699

mdinger opened this issue Feb 23, 2015 · 2 comments

Comments

@mdinger
Copy link
Contributor

mdinger commented Feb 23, 2015

In regex, the consts have these types:

pub static PERLD: &'static &'static [(char, char)] = ...
pub static PERLS: &'static &'static [(char, char)] = ...
pub static PERLW: &'static [(char, char)] = ...

They should probably be the same type but aren't for some reason. They cause this rust-lang/rfcs#730 issue.
@steveklabnik steveklabnik mentioned this issue Feb 23, 2015
Closed
@steveklabnik steveklabnik reopened this Feb 23, 2015
@steveklabnik
Copy link
Member

Ugh, sorry, this is an issue with the regexes in libunicode, not regex in general.

@mdinger mdinger changed the title regex consts should have the same form if possible libunicode regex consts should have the same form if possible Feb 23, 2015
@mdinger
Copy link
Contributor Author

mdinger commented Apr 26, 2015

PERLD and it's friends seem to be gone which fixes this. What crate did they move into?

@mdinger mdinger closed this as completed Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @mdinger