Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document environment variables #23527

Merged
merged 1 commit into from
Mar 20, 2015
Merged

Document environment variables #23527

merged 1 commit into from
Mar 20, 2015

Conversation

steveklabnik
Copy link
Member

Fixes #16330

My troff is probably poor, so make sure that all looks okay.

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton
alexcrichton reviewed Mar 19, 2015
View reviewed changes
man/rustc.1
.TP
\fBRUST_REGION_GRAPH_NODE\fR
Works with `-Z print-region-graph`. Only produces output for the node ID provided
via this variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a somewhat unstable option, so perhaps it (and RUST_REGION_GRAPH below) could be left out?

@steveklabnik
Copy link
Member Author

@alexcrichton all nits should be addressed. I removed THREADs, but may want to double check that we really do real quick.

@alexcrichton
Copy link
Member

r=me with removal of RUST_REGION_GRAPH_NODE and RUST_REGION_GRAPH

@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Mar 19, 2015

📌 Commit eb032af has been approved by alexcrichton

huonw
huonw reviewed Mar 19, 2015
View reviewed changes
man/rustc.1
which link to the standard library.

.TP
\fBRUST_TEST_TASKS\fR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TASKS -> THREADS given #23525 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, that got approved

@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Mar 19, 2015

📌 Commit b4a72a4 has been approved by alexcrichton

@sanxiyn
Copy link
Member

sanxiyn commented Mar 20, 2015

According to man-pages(7), ENVIRONMENT is the traditional heading, not ENVIRONMENT VARIABLES. I think there is no need to deviate from the convention.

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 20, 2015
@Manishearth
Rollup merge of rust-lang#23527 - steveklabnik:gh16330, r=alexcrichton
83a95b0 
 Fixes rust-lang#16330

My troff is probably poor, so make sure that all looks okay.
@bors bors merged commit b4a72a4 into rust-lang:master Mar 20, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 20, 2015
@steveklabnik
environment variables -> environment
8f0de74 
As @sanxiyn says,
rust-lang#23527 (comment)
@steveklabnik steveklabnik mentioned this pull request Mar 20, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 21, 2015
@Manishearth
Rollup merge of rust-lang#23555 - steveklabnik:environment, r=sanxiyn
1677c6a 
 As @sanxiyn says,
rust-lang#23527 (comment)
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 22, 2015
@Manishearth
Rollup merge of rust-lang#23555 - steveklabnik:environment, r=sanxiyn
78b61be 
 As @sanxiyn says,
rust-lang#23527 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document any supported environment variables rustc honours
7 participants
@steveklabnik @rust-highfive @alexcrichton @bors @sanxiyn @huonw @pcwalton