Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression compiling glium #25478

Closed
XMPPwocky opened this issue May 16, 2015 · 9 comments
Closed

Performance regression compiling glium #25478

XMPPwocky opened this issue May 16, 2015 · 9 comments
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@XMPPwocky
Copy link
Contributor

http://github.com/tomaka/glium

Used to take <10 minutes to compile in release builds, but with nightly (5/15/15) I'm sitting at around the 2-hour mark and it's still not done building.

@shepmaster
Copy link
Member

Perhaps related to #25393?

@steveklabnik steveklabnik added the I-slow Issue: Problems and improvements with respect to performance of generated code. label May 18, 2015
@Ryman
Copy link
Contributor

Ryman commented Nov 22, 2015

I think this was fixed by the related issue? Otherwise we would probably still be hearing about it?

@MagaTailor
Copy link

MagaTailor commented Jul 4, 2016

Seeing as this issue was never closed, glium currently takes a few hours (never timed it, but probably around 4-5) on my ARM machine whereas in the past it used to take, IIRC, 10-15 or maybe even fewer minutes. Seems like a huge regression.

@arielb1
Copy link
Contributor

arielb1 commented Jul 4, 2016

Are you using -Z orbit? Could you give us the output of -Z time-passes?

@MagaTailor
Copy link

MagaTailor commented Jul 4, 2016

I'll have to leave it running overnight. And yes, I default to -Z orbit.

glium-0.13.5_time_flies.txt from rustc 1.11.0-dev (8a50e295f 2016-07-02)

@nikomatsakis
Copy link
Contributor

Is this still an issue?

@nikomatsakis nikomatsakis added the A-mir Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Jul 28, 2016
@eddyb
Copy link
Member

eddyb commented Jul 28, 2016

@petevine Do you have the timings without -Z orbit? The issue is older than MIR trans.

@MagaTailor
Copy link

MagaTailor commented Jul 28, 2016

It's the same issue as the linked one, I already OK'ed @jschievink's findings. (compilation time back to normal)

@eddyb
Copy link
Member

eddyb commented Jul 28, 2016

Alright then, the original issue appears to have been fixed long ago.

@eddyb eddyb removed the A-mir Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Jul 28, 2016
@eddyb eddyb closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Development

No branches or pull requests

8 participants