Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compile time of parser combinators such as Combine #36918

Closed
DemiMarie opened this issue Oct 3, 2016 · 2 comments
Closed

Improve compile time of parser combinators such as Combine #36918

DemiMarie opened this issue Oct 3, 2016 · 2 comments
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@DemiMarie
Copy link
Contributor

Currently, parser combinator libraries such as Combine require a very long time to type-check. This does not happen with similar Haskell libraries.

This bug can be considered resolved when such libraries do not take too much time to type check.

@bluss bluss added the I-slow Issue: Problems and improvements with respect to performance of generated code. label Oct 3, 2016
@bluss
Copy link
Member

bluss commented Oct 3, 2016

Please make the issue as specific and actionable as possible. It's best to report specific, measurable issues – they often get fixed!

For example the issue could specify a code snippet that uses combine, the version of the crate, the version of the compiler, and how long it takes to compile.

Previous combine issue: #21231 is fixed since Rust 1.11.

Current PR #36917 will have a positive impact.

@DemiMarie
Copy link
Contributor Author

Seeing as the underlying issue Marwes/combine#21 was closed, I will close this ticket. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Development

No branches or pull requests

2 participants