std: Add ToString trait specialization for Cow<'a, str> and String #39440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small quibble, but can't we do this one as just There's another subtle case that might benefit, |
|
Can you squash this into one commit, and then update pr title and description to match the new content? A reviewer can use r=me when that is done. Thanks |
|
Thank you for your patient guidance. r? @bluss |
F001
changed the title
|
@bors r+ thanks! |
|
📌 Commit dfcca54 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 4, 2017
std: Add ToString trait specialization for Cow<'a, str> and String There is a specialized version of ToString for str type in std. I think there are other types can also benefit from specialization. `Cow` and `String` are the most obvious one. r? @bluss
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a specialized version of ToString for str type in std. I think there are other types can also benefit from specialization.
CowandStringare the most obvious one.r? @bluss