Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test generated manifests against rustup #41767

Closed
Diggsey opened this issue May 5, 2017 · 3 comments
Closed

Test generated manifests against rustup #41767

Diggsey opened this issue May 5, 2017 · 3 comments

Comments

@Diggsey
Copy link
Contributor

Diggsey commented May 5, 2017

Several times, PRs have changed the format of the manifests in such a way that they can no longer be installed by rustup. This results in the corresponding nightlies being uninstallable, and doesn't give much time to fix it before the next nightly: rust-lang/rustup#1092 (comment)

We should add tests to catch these problems before they occur.

cc @brson @alexcrichton

@ranma42
Copy link
Contributor

ranma42 commented May 5, 2017

cc me

@alexcrichton
Copy link
Member

Seems like a good idea! The best location for this may actually be the final integration point, rust-central-station as that's where the manifest is actually generated. If someone would like to implement this I can try to help guide you through the steps!

@Mark-Simulacrum
Copy link
Member

Closing in favor of rust-lang/rust-central-station#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants