Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17.0 powerpc64le test failure: compile-fail/asm-src-loc.rs #42532

Closed
infinity0 opened this issue Jun 8, 2017 · 2 comments
Closed

1.17.0 powerpc64le test failure: compile-fail/asm-src-loc.rs #42532

infinity0 opened this issue Jun 8, 2017 · 2 comments
Labels
C-bug Category: This is a bug. O-PowerPC Target: PowerPC processors

Comments

@infinity0
Copy link
Contributor

Due to #42476 and #39015 I am now passing --disable-optimize-tests to ./configure. But now I get a test failure:

error: /home/infinity0/upstream/rustc-1.17.0+dfsg2/src/test/compile-fail/asm-src-loc.rs:1: unexpected "error": '1:1: 1:1: <inline asm>:1:2: error: unrecognized instruction mnemonic'

error: /home/infinity0/upstream/rustc-1.17.0+dfsg2/src/test/compile-fail/asm-src-loc.rs:17: expected error not found: instruction

error: 1 unexpected errors found, 1 expected errors not found
status: exit code: 101
command: /home/infinity0/upstream/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage2/bin/rustc /home/infinity0/upstream/rustc-1.17.0+dfsg2/src/test/compile-fail/asm-src-loc.rs -L /home/infinity0/upstream/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-g
nu/test/compile-fail --target=powerpc64le-unknown-linux-gnu --error-format json -L /home/infinity0/upstream/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/test/compile-fail/asm-src-loc.stage2-powerpc64le-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic
 -o /home/infinity0/upstream/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/test/compile-fail/asm-src-loc.stage2-powerpc64le-unknown-linux-gnu -Crpath -Lnative=/home/infinity0/upstream/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/native/rust-test-he
lpers
unexpected errors (from JSON output): [
    Error {
        line_num: 1,
        kind: Some(
            Error
        ),
        msg: "1:1: 1:1: <inline asm>:1:2: error: unrecognized instruction mnemonic"
    }
]

not found errors (from test file): [
    Error {
        line_num: 17,
        kind: Some(
            Error
        ),
        msg: "instruction"
    }
]

For reference, this is the test.

I am in a dilemma because I don't know the best way forward now. If I give:

I could ignore the test on ppc64el but it seems quite important, is there a way to patch rust to fix it instead?

@sanxiyn sanxiyn added the O-PowerPC Target: PowerPC processors label Jun 8, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
@programmerjake
Copy link
Member

from testing in rust.godbolt.org this appears to be fixed on nightly

@workingjubilee
Copy link
Contributor

workingjubilee commented Jul 19, 2022

I would have thought this would have found the error correctly because it emitted an error containing the phrase "instruction"... nonetheless, this test was for a now-deprecated form of inline assembly that we don't support. Thank you Jake for the followup. Between these facts, this should not be an issue anymore. Closing.

@workingjubilee workingjubilee closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-PowerPC Target: PowerPC processors
Projects
None yet
Development

No branches or pull requests

5 participants