Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target_env for x86_64-unknown-linux-gnux32 #45390

Closed
malbarbo opened this issue Oct 19, 2017 · 2 comments
Closed

target_env for x86_64-unknown-linux-gnux32 #45390

malbarbo opened this issue Oct 19, 2017 · 2 comments

Comments

@malbarbo
Copy link
Contributor

The target x86_64-unknown-linux-gnux32 was added to rustc with target_env = "gnu".

I was wondering if it should be "gnux32" because of this llvm definition.

Here are the target_env for some rustc targets:

mips-unknown-linux-uclibc -> uclibc
x86_64-unknown-linux-musl -> musl
mips64el-unknown-linux-gnuabi64 -> gnu
armv7-unknown-linux-gnueabihf -> gnu

What do you think?

@alexcrichton
Copy link
Member

I'd probably stick with "gnu" as this is differentiated by target_pointer_width, and otherwise anything with target_env = "gnu" is basically just going to get a new cfg for gnux32 as well (if we add it)

@malbarbo
Copy link
Contributor Author

Thanks @alexcrichton. Let's keep "gnu" then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants