Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLL: regression test for "dropck: track order of destruction for r-value temporaries" #54355

Merged
merged 1 commit into from Sep 27, 2018

Conversation

pnkfelix
Copy link
Member

Once this lands, we can remove the E-needstest from #22323.

(We shouldn't close the bug itself, however, because we are leaving the NLL-fixed-by-NLL bugs open until NLL is turned on by default.)

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2018
@memoryruins memoryruins added the A-NLL Area: Non Lexical Lifetimes (NLL) label Sep 19, 2018
@TimNN
Copy link
Contributor

TimNN commented Sep 25, 2018

Ping from triage @aturon, this PR requires your review.

@davidtwco
Copy link
Member

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned aturon Sep 27, 2018
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2018

📌 Commit 3feffd4 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2018
@bors
Copy link
Contributor

bors commented Sep 27, 2018

⌛ Testing commit 3feffd4 with merge c9865b1...

bors added a commit that referenced this pull request Sep 27, 2018
NLL: regression test for "dropck: track order of destruction for r-value temporaries"

Once this lands, we can remove the E-needstest from #22323.

(We shouldn't close the bug itself, however, because we are leaving the NLL-fixed-by-NLL bugs open until NLL is turned on by default.)
@bors
Copy link
Contributor

bors commented Sep 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: davidtwco
Pushing c9865b1 to master...

@bors bors merged commit 3feffd4 into rust-lang:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NLL Area: Non Lexical Lifetimes (NLL) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants