You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's intended to be moved to core at some point (there's a few ways to reimplement it, embrio-async's implementation is one but has some relatively spread out safety guarantees, adding the ability for generators to take resume arguments is another that I think would avoid needing any unsafe code at all).
I thought this was already noted on the tracking issue (#50547), but looking at it again it doesn't appear so, adding this issue to the unresolved questions would probably be useful.
Reacted by WildCryptoFox, Valentyn Valiaiev, Scott J Maddox and Luo Jia / Zhouqi Jiang
Marking as not blocking for stabilization. Obviously we want things to work from core eventually, but it's ok if that doesn't work to start. Moreover, the major blocker here is resolving how generator arguments should work -- once that works, it seems clear that we'll be able to solve this.
Activity
bjorn3 commentedon Dec 13, 2018
It uses thread local storage, which isnt available outside libstd.
WildCryptoFox commentedon Dec 13, 2018
@bjorn3 Hm. So it does. Looks like @Nemo157 's embrio fills the spot.
https://github.com/Nemo157/embrio-rs/blob/master/embrio-async/dehygiene/src/lib.rs
Nemo157 commentedon Dec 13, 2018
It's intended to be moved to
coreat some point (there's a few ways to reimplement it,embrio-async's implementation is one but has some relatively spread out safety guarantees, adding the ability for generators to take resume arguments is another that I think would avoid needing anyunsafecode at all).I thought this was already noted on the tracking issue (#50547), but looking at it again it doesn't appear so, adding this issue to the unresolved questions would probably be useful.
WildCryptoFox commentedon Dec 13, 2018
Thanks @Nemo157
nikomatsakis commentedon Mar 5, 2019
Marking as not blocking for stabilization. Obviously we want things to work from core eventually, but it's ok if that doesn't work to start. Moreover, the major blocker here is resolving how generator arguments should work -- once that works, it seems clear that we'll be able to solve this.
cramertj commentedon Sep 4, 2019
Closing this in favor of #56974