Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly broken with pear_codegen ( & rocket ? ) #57120

Closed
Asone opened this issue Dec 25, 2018 · 3 comments
Closed

Nightly broken with pear_codegen ( & rocket ? ) #57120

Asone opened this issue Dec 25, 2018 · 3 comments

Comments

@Asone
Copy link

Asone commented Dec 25, 2018

Hi,

version information

rustup 1.16.0 (beab5ac2b 2018-12-06)
cargo 1.33.0-nightly (2cf1f5dda 2018-12-11)
rustc 1.33.0-nightly (ddab10a69 2018-12-23)

description of bug

Lately in a rust project it seems our pipe has broken with last versions of rust nightly, Rocket and Pear_codegen.

After a few research it seems we have a problem kind of similar with the following issue which attributed the break to rust nightly so i open up the issue here. If i'm wrong feel free to close the issue.

I've tried to build up a docker container with the same parameters used in the pipe and get the same problem.

Here's the stacktrace :

error[E0599]: no variant named `concat` found for type `syntax::tokenstream::TokenStream` in the current scope
   --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/pear_codegen-0.0.20/src/lib.rs:330:54
    |
330 |                 mac.node.tts = ThinTokenStream::from(TokenStream::concat(streams));
    |                                                      ^^^^^^^^^^^^^^^^^^^ variant not found in `syntax::tokenstream::TokenStream`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: Could not compile `pear_codegen`.

you can check the pipe and errors more in details here for a specific build and here for the history of builds.

I've been checking this file as it seemed referenced in the stacktrace :

/usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/pear_codegen-0.0.20/src/lib.rs:330:54

However the file doesn't seem to be the right one as there is no line n°330.

Unfortunately my knowledge of rust is not extended enough to provide with deeper knowledge of the bug. If there's any additional information that you need me to provide, please feel free to notify me.

Also, any explanation to understand how this happens/how to fix that kind of issues is welcome in order to give help if i can.

Thank you.

P.S : i'll open a similar issue on pear repo in order to notify of the bug and get it fixed if it comes from there.

@Asone Asone changed the title Nightly broken with Rocket Nightly broken with pear_codegen ( & rocket ? ) Dec 25, 2018
@Aaron1011
Copy link
Member

TokenStream::concat appears to have been renamed to TokenStream::new in commit e80c7dd

@jebrosen
Copy link
Contributor

Core functionality of Rocket 0.3 is broken on nightly since rustc 2018-12-06 or so anyway -- it won't help much to fix pear_codegen. The best course of action here is to upgrade to Rocket 0.4, and if that's not possible yet downgrade the nightly toolchain to one earlier than 2018-12-06.

@Asone
Copy link
Author

Asone commented Dec 27, 2018

as per @jebrosen recommended, the project has been updated to rocket 0.4.

I close the current ticket as it is not fixable itself and our pipeline is effective with the new version of rocket.

Thanks for the quick answers !

Much datalove !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants