Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGILL in byond #57941

Closed
Mark-Simulacrum opened this issue Jan 28, 2019 · 2 comments
Closed

SIGILL in byond #57941

Mark-Simulacrum opened this issue Jan 28, 2019 · 2 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

I suspect this is actually just UB -- https://github.com/PJB3005/byond-rs/blob/master/src/call.rs#L77-L79 looks like it's storing pointers to freed memory -- but I could be misinterpreting, so filing an issue for further investigation.

https://crater-reports.s3.amazonaws.com/beta-1.33-1/beta-2019-01-22/reg/byond-0.3.2/log.txt

cc @PJB3005

@Mark-Simulacrum Mark-Simulacrum added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jan 28, 2019
@PJB3005
Copy link

PJB3005 commented Jan 28, 2019

I've been cc'd on here before for UB. Isn't the issue that I'm testing panics across extern C boundaries or did something else break this time? I've been too lazy to fix the tests.

I don't see how the code linked has use after free, the cstrs are stored in a vec so they're freed only after the callback is finished. I could be wrong though.

@Mark-Simulacrum
Copy link
Member Author

Ah, yes, I missed the cstr vec. If there's a panic across an ABI boundary then that would be the cause here most likely. Since that change in behavior is expected, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants