Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: emit time spent for each test suite #59437

Open
pnkfelix opened this issue Mar 26, 2019 · 2 comments
Open

compiletest: emit time spent for each test suite #59437

pnkfelix opened this issue Mar 26, 2019 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@pnkfelix
Copy link
Member

Right now we have test suites with thousands of files each. It would be useful for compiletest to indicate how long it takes when it runs each such suite, so that someone reviewing where time is going during testing can know where the bulk of time overall is being spent without having to stare at the output holding a stopwatch.

@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 26, 2019

or wait, is that what the "finished in NNN.NNN" (where N is a digit) means?

If those lines represent timings, they should have units. And they should indicate on the line itself what is being timed, because I see output like this:

...
test result: ok. 2950 passed; 0 failed; 9 ignored; 0 measured; 0 filtered out

        finished in 112.679
        finished in 224.578
Check compiletest suite=mir-opt mode=mir-opt (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
...

and I shouldn't have to attempt to parse the backscroll to figure out what those two "finished in ..." lines each individually mean.

@varkor varkor added the A-testsuite Area: The testsuite used to check the correctness of rustc label Mar 26, 2019
@pnkfelix pnkfelix added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 26, 2019
@pnkfelix
Copy link
Member Author

(also, I am assuming that while compiletest can be configured to run multiple tests in parallel, it never runs multiple test suites in parallel. If this is false, please do let me know.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

2 participants