Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#60874 #60893

Closed
rust-highfive opened this issue May 16, 2019 · 2 comments
Closed

rls no longer builds after rust-lang/rust#60874 #60893

rust-highfive opened this issue May 16, 2019 · 2 comments
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60874, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @ehuss, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @alexcrichton, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2019
@alexcrichton
Copy link
Member

cc @rust-lang/release as well, this is likely to impact the beta branch next week.

Additionally changes to checkregression.py need to be backed out ASAP (e.g. during and after the beta branch)

@oli-obk
Copy link
Contributor

oli-obk commented May 19, 2019

fixed in #60946

@oli-obk oli-obk closed this as completed May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants