Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: remember the selected crate in search #62929

Closed
pravic opened this issue Jul 24, 2019 · 4 comments · Fixed by #62941 or #66514
Closed

Documentation: remember the selected crate in search #62929

pravic opened this issue Jul 24, 2019 · 4 comments · Fixed by #62941 or #66514
Assignees
@GuillaumeGomez
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pravic
Copy link
Contributor

pravic commented Jul 24, 2019

Right now it is allowed to select whether we want to search within all crates or in the specific ones (e.g. core, std, etc).

It would be really useful to remember the selected option, because in most cases we want to search in the std crate only.

cc @GuillaumeGomez
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 24, 2019
@GuillaumeGomez
Copy link
Member

Good idea!

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 24, 2019
Merged
@bors bors closed this as completed in 0414dfa Aug 29, 2019
@pravic
Copy link
Contributor Author

pravic commented Nov 13, 2019 •
edited

Does not work, neither in stable nor nightly.

@GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Indeed, will take a look quickly.

@GuillaumeGomez GuillaumeGomez self-assigned this Nov 18, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Nov 18, 2019
Merged
@bors bors closed this as completed in 4bd9168 Nov 20, 2019
@pravic
Copy link
Contributor Author

pravic commented Nov 26, 2019

Works perfectly now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
3 participants
@pravic @jonas-schievink @GuillaumeGomez