Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error code for "union patterns should have exactly one field" #70620

Open
artemmukhin opened this issue Mar 31, 2020 · 2 comments
Open

No error code for "union patterns should have exactly one field" #70620

artemmukhin opened this issue Mar 31, 2020 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@artemmukhin
Copy link
Contributor

It would be nice to have a specific error code for union patterns should have exactly one field error. Currently, there is no such code.
@jonas-schievink jonas-schievink added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 31, 2020
@artemmukhin artemmukhin mentioned this issue Mar 31, 2020
Merged
@Centril
Copy link
Contributor

Centril commented Mar 31, 2020

We don't have error codes for most errors in the compiler. I don't know that it makes sense to file issues when one is missing. It would be easier to make a PR directly instead.

@artemmukhin
Copy link
Contributor Author

OK, I will try to make a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Centril @jonas-schievink @artemmukhin