Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment TyCtxt::err to be available via TyCxAt #72619

Closed
mark-i-m opened this issue May 26, 2020 · 0 comments · Fixed by #73176
Closed

Augment TyCtxt::err to be available via TyCxAt #72619

mark-i-m opened this issue May 26, 2020 · 0 comments · Fixed by #73176
Assignees
@LeSeulArtichaut
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@mark-i-m
Copy link
Member

#70551 (comment)

Also it might be cool to use the TyCxAt helper to have tcx.at(span).err() use the span for the delay_span_bug, since I assume many of the callers of tcx.err() have a span around.

cc @eddyb
@mark-i-m mark-i-m mentioned this issue May 26, 2020
Merged
@jonas-schievink jonas-schievink added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 26, 2020
@LeSeulArtichaut LeSeulArtichaut self-assigned this Jun 9, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Jun 9, 2020
Merged
@bors bors closed this as completed in 9b4db69 Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeSeulArtichaut LeSeulArtichaut

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TyCtxtAt::{ty_error, ty_error_with_message} LeSeulArtichaut/rust
3 participants
@jonas-schievink @mark-i-m @LeSeulArtichaut