Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link failure (in alloc, readelf) in proc-macro crate, stable regression 1.44.0 -> 1.44.1 #73970

Closed
cristicbz opened this issue Jul 2, 2020 · 8 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@cristicbz
Copy link
Contributor

This is fixed in 1.45.0-beta.3 and 1.46.0-nightly (f781bab 2020-07-01), but since there's no workaround that I can see, I don't know if this warrants a point release. If not, feel free to close of course.

I reduced one of my dependencies (psl_codegen) which broke in 1.44.1 to the following (available at https://github.com/cristicbz/rust-regression-441 as well):

Cargo.toml:

[package]
name = "regression-441"
version = "0.1.0"

[lib]
proc-macro = true

[dependencies]
error-chain = "0.12.2"

src/lib.rs:

extern crate error_chain;
extern crate proc_macro;

#[proc_macro_derive(Foo, attributes(foo))]
pub fn derive_foo(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
     input
}

With rust 1.44.1 I'm seeing:

Link failure
(env-rw) ca•~/p/regression-441(master)» rustc --version
rustc 1.44.1 (c7087fe00 2020-06-17)
(env-rw) ca•~/p/regression-441(master)» cargo build
   Compiling regression-441 v0.1.0 (/home/ccc/p/regression-441)
error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.19vlslsl4nvz2nyu.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.1flqwsbfsd7ooldx.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.1i8m4tznh5762ur2.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.1jl0yhp4m5e4f893.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.1sl0i9nbqswm4bj7.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.1yc699hchbcg3irz.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.21j3omrt84pjkssb.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.227uioi392b4ewxc.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.25ks6dj59pgwfoki.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.28jri2xbccu00vwm.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.2o5u7qxg32bo6sxe.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.2tbf2qv6tyujo2pz.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.2udkubercaxr5uwz.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.32dq833cs3aueypx.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.33edgal75bib4bac.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.35vrj1stsffnh0o0.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.3d4hetg9d7e5sbsw.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.3nj3vxtm5xznqk12.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.3ufc80eyvk4usbt5.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.42kol4rpvk4yrwcr.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.4ti1f84gexxj1lbq.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.4uqnlql52iqm56t5.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.4yvzexy0awyal4nf.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.58xksz7rhj716jay.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.5e8bm9we5p7482r9.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.9ybtckfw5pz2r0d.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.k8vf19r1diybyau.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.mbln18r5lslop91.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.qx1k7qxy173hol.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.u5lgvpyan0lio70.rcgu.o" "-o" "/home/ccc/p/regression-441/target/debug/deps/libregression_441-5f4d861a543295bb.so" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.2638fnoxvowf0mdt.rcgu.o" "/home/ccc/p/regression-441/target/debug/deps/regression_441-5f4d861a543295bb.4k8m42t3piqx36xo.rcgu.o" "-Wl,--gc-sections" "-Wl,-zrelro" "-Wl,-znow" "-nodefaultlibs" "-L" "/home/ccc/p/regression-441/target/debug/deps" "-L" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libproc_macro-2182d442523e19c8.rlib" "/home/ccc/p/regression-441/target/debug/deps/liberror_chain-5807239afa7bfc6e.rlib" "/home/ccc/p/regression-441/target/debug/deps/libbacktrace-46766d8b7e4a07ab.rlib" "/home/ccc/p/regression-441/target/debug/deps/libminiz_oxide-b3dd034d72316d92.rlib" "/home/ccc/p/regression-441/target/debug/deps/libadler32-c864a7ffa7fb7c71.rlib" "/home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib" "/home/ccc/p/regression-441/target/debug/deps/liblibc-5fc91ccf77c1716c.rlib" "/home/ccc/p/regression-441/target/debug/deps/libaddr2line-1e38689506db23b0.rlib" "/home/ccc/p/regression-441/target/debug/deps/libgimli-0907f659052c8f8d.rlib" "/home/ccc/p/regression-441/target/debug/deps/libcfg_if-b132ac4d666ef9b8.rlib" "/home/ccc/p/regression-441/target/debug/deps/librustc_demangle-c73cb2363aa21251.rlib" "-Wl,--start-group" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-6640d3868fa846e8.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-48481e446108229f.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhashbrown-bfdf9e1c331f914a.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-991e68a3d0300af6.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libbacktrace-74304cfed66bbabf.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libbacktrace_sys-5db30a83f5489d12.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_demangle-a106c3f62654e72c.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-3d6b30695af38106.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcfg_if-d8f11f6bb46ba3ee.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-60c81ab95e289dd1.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-fd1a416f10d6c43d.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_core-4a2bd2b60cccd1fb.rlib" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-7ea8ebc630055039.rlib" "-Wl,--end-group" "/home/ccc/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-f7cd12d3ecd59a89.rlib" "-Wl,-Bdynamic" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-ldl" "-lutil" "-ldl" "-lrt" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-ldl" "-lutil" "-shared"
  = note: /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.1.rcgu.o): in function `alloc::slice::<impl [T]>::sort_by_key::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/liballoc/slice.rs:295: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::symbol_map::{{closure}}'
          /usr/bin/ld: /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/liballoc/slice.rs:295: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::symbol_map::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.1.rcgu.o): in function `alloc::slice::<impl [T]>::sort_by_key::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/liballoc/slice.rs:295: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::symbol_map::{{closure}}'
          /usr/bin/ld: /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/liballoc/slice.rs:295: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::symbol_map::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.4.rcgu.o): in function `core::iter::traits::iterator::Iterator::find::check::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/iter/traits/iterator.rs:2208: undefined reference to `object::read::elf::symbol::SymbolTable<Elf>::parse::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.4.rcgu.o): in function `core::iter::traits::iterator::Iterator::find::check::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/iter/traits/iterator.rs:2208: undefined reference to `object::read::elf::symbol::SymbolTable<Elf>::parse::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.4.rcgu.o): in function `core::iter::traits::iterator::Iterator::find::check::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/iter/traits/iterator.rs:2208: undefined reference to `object::read::elf::symbol::SymbolTable<Elf>::parse::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.4.rcgu.o): in function `core::iter::traits::iterator::Iterator::find::check::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/iter/traits/iterator.rs:2208: undefined reference to `object::read::elf::symbol::SymbolTable<Elf>::parse::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.4.rcgu.o): in function `core::iter::adapters::map_try_fold::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/iter/adapters/mod.rs:793: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::symbol_map::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.4.rcgu.o): in function `core::iter::adapters::map_try_fold::{{closure}}':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/iter/adapters/mod.rs:793: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::symbol_map::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::map':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:456: undefined reference to `object::read::elf::symbol::SymbolTable<Elf>::parse::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::map':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:456: undefined reference to `object::read::elf::file::ElfFile<Elf>::raw_section_by_name::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::map':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:456: undefined reference to `object::read::elf::symbol::SymbolTable<Elf>::parse::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::map':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:456: undefined reference to `<object::read::elf::symbol::ElfSymbolIterator<Elf> as core::iter::traits::iterator::Iterator>::next::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::map':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:456: undefined reference to `object::read::elf::file::ElfFile<Elf>::raw_section_by_name::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::map':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:456: undefined reference to `<object::read::elf::symbol::ElfSymbolIterator<Elf> as core::iter::traits::iterator::Iterator>::next::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::or_else':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:766: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::section_by_name::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::or_else':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:766: undefined reference to `<object::read::elf::file::ElfFile<Elf> as object::read::traits::Object>::section_by_name::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::and_then':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:670: undefined reference to `object::read::elf::symbol::parse_symbol::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libobject-8e621d62a2f9d6e1.rlib(object-8e621d62a2f9d6e1.object.9675m3cb-cgu.7.rcgu.o): in function `core::option::Option<T>::and_then':
          /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7/src/libcore/option.rs:670: undefined reference to `object::read::elf::symbol::parse_symbol::{{closure}}'
          /usr/bin/ld: /home/ccc/p/regression-441/target/debug/deps/libregression_441-5f4d861a543295bb.so: hidden symbol `_ZN6object4read3elf4file18ElfFile$LT$Elf$GT$19raw_section_by_name28_$u7b$$u7b$closure$u7d$$u7d$17h39264e8cc08853e8E' isn't defined
          /usr/bin/ld: final link failed: bad value
          collect2: error: ld returned 1 exit status


error: aborting due to previous error

error: could not compile `regression-441`.

With rust 1.44.0 this compiles just fine:

Build success
(env-rw) ca•~/p/regression-441(master)» rustup override set 1.44.0
info: using existing install for '1.44.0-x86_64-unknown-linux-gnu'
info: override toolchain for '/home/ccc/p/regression-441' set to '1.44.0-x86_64-unknown-linux-gnu'

  1.44.0-x86_64-unknown-linux-gnu unchanged - rustc 1.44.0 (49cae5576 2020-06-01)

(env-rw) ca•~/p/regression-441(master)» cargo build
   Compiling libc v0.2.71
   Compiling version_check v0.9.2
   Compiling gimli v0.21.0
   Compiling adler32 v1.1.0
   Compiling object v0.20.0
   Compiling rustc-demangle v0.1.16
   Compiling cfg-if v0.1.10
   Compiling miniz_oxide v0.3.7
   Compiling error-chain v0.12.2
   Compiling addr2line v0.12.2
   Compiling backtrace v0.3.49
   Compiling regression-441 v0.1.0 (/home/ccc/p/regression-441)
    Finished dev [unoptimized + debuginfo] target(s) in 0.99s

I'm on ubuntu 20.04, with the following gcc and ld versions:

(env-rw) ca•~/p/regression-441(master)» ld --version
GNU ld (GNU Binutils for Ubuntu) 2.34
Copyright (C) 2020 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public Licence version 3 or (at your option) a later version.
This program has absolutely no warranty.

(env-rw) ca•~/p/regression-441(master)» cc --version
cc (Ubuntu 9.3.0-10ubuntu2) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
@cristicbz cristicbz added the C-bug Category: This is a bug. label Jul 2, 2020
@jonas-schievink jonas-schievink added A-linkage Area: linking into static, shared libraries and binaries regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2020
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 2, 2020
@LeSeulArtichaut LeSeulArtichaut removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 2, 2020
@LeSeulArtichaut
Copy link
Contributor

Removing I-prioritize as the issue is already fixed.
cc @rust-lang/release for the question about having a point release.

@jonas-schievink
Copy link
Contributor

What caused/fixed this?

@cuviper
Copy link
Member

cuviper commented Jul 2, 2020

I tried your repo on Fedora 32 using upstream 1.44.0 and 1.44.1, and both compiled successfully.

@LeSeulArtichaut
Copy link
Contributor

Maybe related to #73493?

@Mark-Simulacrum
Copy link
Member

This looks like an incremental bug perhaps? I don't know that we've found all the cases yet -- I seem to recall a PR by @pnkfelix that suggested that it may have identified the root cause of these?

@pietroalbini
Copy link
Member

We're going to have a release in two weeks, so I'm not sure a point release is worth it anyway.

@cristicbz
Copy link
Contributor Author

I don't think this is incremental, since it happens with [profile.dev] incremental=false too. It also happens right after cargo clean. Looks kinda similar to #69328 , but there's a comment on there that claims it was fixed, so i'm not sure.

@cristicbz
Copy link
Contributor Author

In a docker container this works just fine, so clearly there's something seriously off with my environment:

FROM ubuntu:20.04
RUN apt-get update && apt-get install -qyy curl binutils build-essential git
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN ln -s /root/.cargo/bin/* /usr/bin/
RUN git clone https://github.com/cristicbz/rust-regression-441
WORKDIR /rust-regression-441
RUN cargo build

Not sure what could possibly cause this, sorry about the noise I thought I was pretty thorough in trying different versions and reinstalling, but clearly there's something else weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkage Area: linking into static, shared libraries and binaries C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants