Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuple structs should generate the same code as structs #7435

Closed
emberian opened this issue Jun 27, 2013 · 4 comments
Closed

tuple structs should generate the same code as structs #7435

emberian opened this issue Jun 27, 2013 · 4 comments
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@emberian
Copy link
Member

Right now tuple structs generate code very similar to/identical to enums. afaict no reason for this.

@pythonesque
Copy link
Contributor

I'm going to take a shot at this.

@thestinger
Copy link
Contributor

@cmr: what exactly do you mean by that?

@emberian
Copy link
Member Author

@thestinger tuple structs are translated as enums, which leads to some ugly IR. I can pull up examples when I have time later in the week if they'd be useful.

@emberian
Copy link
Member Author

Now that we inline enum constructors I think we're golden. My complaints before (but poorly expressed) were that struct fields were getting translated into the proper place but enums were going through calls. Codegen looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

3 participants