Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There should be a rustdoc equivalent of RUSTFLAGS_NOT_BOOTSTRAP #75256

Closed
jyn514 opened this issue Aug 7, 2020 · 0 comments · Fixed by #82309
Closed

There should be a rustdoc equivalent of RUSTFLAGS_NOT_BOOTSTRAP #75256

jyn514 opened this issue Aug 7, 2020 · 0 comments · Fixed by #82309
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Aug 7, 2020 •
edited
Loading

RUSTDOCFLAGS is completely ignored and RUSTFLAGS_NOT_BOOTSTRAP passes it to both rustc and rustdoc, which makes things harder to use (e.g. it recompiles libstd when it doesn't need to).
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Aug 7, 2020
@jyn514 jyn514 changed the title There should be a rustdoc equivalent of RUST_FLAGS_NOT_BOOTSTRAP There should be a rustdoc equivalent of RUSTFLAGS_NOT_BOOTSTRAP Dec 21, 2020
@jyn514 jyn514 added the A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself label Dec 21, 2020
@jyn514 jyn514 mentioned this issue Feb 20, 2021
Merged
@bors bors closed this as completed in 3de9b41 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate RUSTDOCFLAGS in the environment when documenting jyn514/rust
1 participant
@jyn514