Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more space below the Rust badge in the README #75915

Closed
wants to merge 1 commit into from
Closed

Add more space below the Rust badge in the README #75915

wants to merge 1 commit into from

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 25, 2020

The extra space makes it easier to read the README.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2020
@camelid camelid changed the title Add more space below the Rust shield in the README Add more space below the Rust badge in the README Aug 25, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 26, 2020

r? @steveklabnik

@steveklabnik
Copy link
Member

I am not sure how I feel about adding an increasing amount of literal HTML in our markdown. I'm not going to block this, but I'm not sure that I think it should be merged either.

@jyn514 jyn514 added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Aug 28, 2020
@camelid
Copy link
Member Author

camelid commented Aug 28, 2020

I understand where you're coming from, I don't love all the HTML either. It just feels cramped to me right now, so that's why I wanted a bit more space:

image

camelid
camelid commented Sep 15, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@camelid
Copy link
Member Author

camelid commented Oct 1, 2020

I changed it to add a horizontal line (in Markdown) instead and I rebased atop master. I can close this if you still would rather not have it, but I think it makes it more readable.

@camelid
Copy link
Member Author

camelid commented Oct 1, 2020

I would actually prefer just a plain-text title (like how it used to be), but I figured other people liked it better the way it looks now.

@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
@Dylan-DPC-zz
Copy link

Closing this as there doesn't seem to be motivation to take this further from the author and the reviewer.

@camelid camelid added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. A-meta Area: Issues about the rust-lang/rust repository. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-meta Area: Issues about the rust-lang/rust repository. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@camelid @rust-highfive @jyn514 @steveklabnik @Dylan-DPC-zz @nikomatsakis @LeSeulArtichaut