Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs for the const keyword #75960

Merged
merged 3 commits into from Sep 2, 2020
Merged

Improve docs for the const keyword #75960

merged 3 commits into from Sep 2, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 26, 2020

@rustbot modify labels: T-doc

@rustbot rustbot added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Aug 26, 2020
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2020
jyn514
jyn514 reviewed Sep 1, 2020
View reviewed changes
library/std/src/keyword_docs.rs Outdated Show resolved Hide resolved
library/std/src/keyword_docs.rs Show resolved Hide resolved
library/std/src/keyword_docs.rs Outdated Show resolved Hide resolved
@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2020
camelid and others added 2 commits September 1, 2020 17:38
@camelid
Minor improvements
54a4fd1 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@camelid
Improve wording for const pointers
ce90478
@jyn514
Copy link
Member

jyn514 commented Sep 2, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 2, 2020

📌 Commit ce90478 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2020
@bors
Copy link
Contributor

bors commented Sep 2, 2020

⌛ Testing commit ce90478 with merge a167485...

@bors
Copy link
Contributor

bors commented Sep 2, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing a167485 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2020
@bors bors merged commit a167485 into rust-lang:master Sep 2, 2020
@camelid camelid deleted the patch-6 branch September 2, 2020 20:43
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@joshtriplett joshtriplett

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@camelid @rust-highfive @jyn514 @bors @cuviper @joshtriplett @Dylan-DPC-zz @rustbot