Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR CI: also run clippy tests #76999

Closed
RalfJung opened this issue Sep 21, 2020 · 1 comment · Fixed by #77016
Closed

PR CI: also run clippy tests #76999

RalfJung opened this issue Sep 21, 2020 · 1 comment · Fixed by #77016
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@RalfJung
Copy link
Member

The PR CI runner currently does not seem to run clippy tests. Would be nice if it would. :)

Cc @Mark-Simulacrum @rust-lang/clippy
@oli-obk oli-obk added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 21, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Sep 21, 2020
Merged
@bors bors closed this as completed in 391136e Nov 10, 2020
@RalfJung
Copy link
Member Author

This had some unintended side-effects: in a rollup like #79056 that touches a clippy file, PR CI runs the "tools" builder, including Miri -- and then PR CI could fail because Miri is broken, even though the PR would land just fine as it is okay for Miri to be broken. (The PR did not update the Miri submodule.)

@est31 est31 mentioned this issue Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test clippy on PR CI on changes Mark-Simulacrum/rust
2 participants
@RalfJung @oli-obk