You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
camelid
changed the title
rustdoc: Implementations on Foreign Types are out-of-order in sidebar
rustdoc: Implementations on Foreign Types are not sorted in sidebar
Nov 3, 2020
I had a quick peek and it looks like the code is in fact already sorting that list, but due to the nature of the sorting algorithm plus the types in the list its a bit unfortunate and that's why we get the Wrapping<T> at the first spot.
If I'm understanding the issue reported correctly we would be able to fix it by first lower-casing the types before compare them and only for sorting
Hmm, I think Wrapping<T> being first is part of what made me think it was a bug, but also that u64 comes before u8. I guess u64 coming first makes sense because it starts with u6 which is "less than" u8, but intuitively it feels weird because I think of u8 as being smaller.
yap, completely understandable, had the same feeling when saw your print-screen :)
Nonetheless I'm happy to submit a PR if it's decided that we should do something here. (don't know if wanna ping someone else for some input)
See in the docs for the
num
crate:The text was updated successfully, but these errors were encountered: