You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dtolnay opened this issue
Nov 21, 2020
· 5 comments
· Fixed by #79300
Labels
A-traitsArea: Trait systemC-bugCategory: This is a bug.F-doc_cfg`#![feature(doc_cfg)]`T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
cargo doc renders this as follows. Notice that the blue banner appears for Eq (I guess because the trait is empty) but not for PartialEq. I believe that it should consistently appear for neither Eq nor PartialEq, orboth Eq and PartialEq.
Expanding the [+] next to impl PartialEq shows the other blue banner but this issue is about the default appearance on page load.
Ohh, the collapse settings are fun; I never noticed this in #78678 because I have rustdoc-collapse: true which seems to imply not collapsing the trait implementations. Clearing that setting from local storage, or if it's set to false does this; I think it should be possible to make it so that having this block there either ignores collapsing so it shows always, (though this may be inconsistent with how it works with functions), or make it default to uncollapsing the trait.
A-traitsArea: Trait systemC-bugCategory: This is a bug.F-doc_cfg`#![feature(doc_cfg)]`T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
cargo doc
renders this as follows. Notice that the blue banner appears for Eq (I guess because the trait is empty) but not for PartialEq. I believe that it should consistently appear for neither Eq nor PartialEq, or both Eq and PartialEq.Expanding the [+] next to impl PartialEq shows the other blue banner but this issue is about the default appearance on page load.
Mentioning
doc(cfg(...))
tracking issue #43781.Mentioning @GuillaumeGomez @Nemo157
The text was updated successfully, but these errors were encountered: