Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not query the HIR directly in opt_associated_item. #80889

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

cjgillot
Copy link
Contributor

Papercut found by @Aaron1011.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2021
@jyn514
Copy link
Member

jyn514 commented Jan 10, 2021

@Aaron1011
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 10, 2021

⌛ Trying commit 21e1963 with merge 94ff5034a337d444f8bb2973062b60d542ff9061...

@bors
Copy link
Contributor

bors commented Jan 11, 2021

☀️ Try build successful - checks-actions
Build commit: 94ff5034a337d444f8bb2973062b60d542ff9061 (94ff5034a337d444f8bb2973062b60d542ff9061)

@rust-timer
Copy link
Collaborator

Queued 94ff5034a337d444f8bb2973062b60d542ff9061 with parent 080ee6f, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (94ff5034a337d444f8bb2973062b60d542ff9061): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Jan 11, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jan 11, 2021

📌 Commit 21e1963 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2021
@jyn514 jyn514 added A-incr-comp Area: Incremental compilation I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2021
@bors
Copy link
Contributor

bors commented Jan 11, 2021

⌛ Testing commit 21e1963 with merge 6526e5c...

@bors
Copy link
Contributor

bors commented Jan 11, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6526e5c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2021
@bors bors merged commit 6526e5c into rust-lang:master Jan 11, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 11, 2021
@cjgillot cjgillot deleted the asa branch January 11, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation I-compiletime Issue: Problems and improvements with respect to compile times. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants