Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: "List of all items" title shown twice #82477

Closed
RalfJung opened this issue Feb 24, 2021 · 3 comments · Fixed by #82484
Closed

rustdoc: "List of all items" title shown twice #82477

RalfJung opened this issue Feb 24, 2021 · 3 comments · Fixed by #82484
Assignees
@bugadani
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Feb 24, 2021 •
edited by rustbot
Loading

As can be seen when going to https://doc.rust-lang.org/nightly/std/all.html, the "List of all items" page generated by rustdoc has a header saying "List of all items List of all items":
Screenshot_2021-02-24 List of all items in this crate
@RalfJung RalfJung added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 24, 2021
@jyn514 jyn514 added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Feb 24, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 24, 2021
@jyn514
Copy link
Member

jyn514 commented Feb 24, 2021

Mentoring instructions: remove this line:

rust/src/librustdoc/html/render/mod.rs

Line 1346 in 6b56603

<span class=\"in-band\">List of all items</span>\

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Feb 24, 2021
@jyn514
Copy link
Member

jyn514 commented Feb 24, 2021

I think this regressed in #81398. cc @bugadani, do you have time to take a look?

@bugadani
Copy link
Contributor

bugadani commented Feb 24, 2021 •
edited
Loading

How did that happen... Whoops, I'll fix asap

As an aside, that bug should've been "List of List of all items" for a bit of wikipedia-plagiarism.

@rustbot claim

@bugadani bugadani mentioned this issue Feb 24, 2021
Merged
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 24, 2021
@bors bors closed this as completed in 8250a25 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bugadani bugadani

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Remove duplicate "List of all items" bugadani/rust
5 participants
@RalfJung @bugadani @apiraino @jyn514 @rustbot