Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tabs in err messages before rendering #83639

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

osa1
Copy link
Contributor

@osa1 osa1 commented Mar 29, 2021

This is done in other call sites, but was missing in one place.

Fixes #83638

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2021
@rust-log-analyzer

This comment has been minimized.

@osa1
Copy link
Contributor Author

osa1 commented Mar 29, 2021

Hm, I need a tab in the test file for this bug, but mingw-check does not allow it. Is there a attribute I can add to allow this?

@est31
Copy link
Member

est31 commented Mar 29, 2021

@osa1 does adding // ignore-tidy-tab work?

@osa1
Copy link
Contributor Author

osa1 commented Mar 29, 2021

@est31 just added that line, let's see if it'll work

@rust-log-analyzer

This comment has been minimized.

This is done in other call sites, but was missing in one place.

Fixes rust-lang#83638
@estebank
Copy link
Contributor

r? @estebank

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2021

📌 Commit 8d7432a has been approved by estebank

@rust-highfive rust-highfive assigned estebank and unassigned lcnr Mar 30, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
@bors
Copy link
Contributor

bors commented Mar 30, 2021

⌛ Testing commit 8d7432a with merge 926ec1c...

@bors
Copy link
Contributor

bors commented Mar 30, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 926ec1c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2021
@bors bors merged commit 926ec1c into rust-lang:master Mar 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 30, 2021
@osa1 osa1 deleted the issue83638 branch March 30, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug assertion failure when error snippet has tab character
8 participants