Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating LLVM-specific feature names for -Ctarget-feature flag #85011

Open
nagisa opened this issue May 6, 2021 · 0 comments
Open
Assignees
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nagisa
Copy link
Member

nagisa commented May 6, 2021

As of #84991 we support the same values for -Ctarget-feature as we do for the #[target_feature] attribute. However there is a fallback that passes through any unknown names, which effectively means that LLVM names are also accepted by the flag.

I think it makes sense for us to look into deprecating LLVM-specific names, and eventually remove the fallback (or destabilize the fallback behaviour).

@nagisa nagisa added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 6, 2021
@nagisa nagisa self-assigned this May 6, 2021
@jonas-schievink jonas-schievink added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants