Preserve more spans in internal rustc_queries! macro

[Aaron1011]

We now preserve the span of the various query modifiers, and
use the span of the query's name for the commas that we
generate to separate the modifiers. This makes debugging issues with the
internal query macro infrastructure much nicer - previously, we
would get errors messages pointing at the entire call site
(the rustc_queries! invocation), which isn't very useful.

This should have no effect when compilation succeeds.

A concrete example of an error message produced after this changed:

error: local ambiguity: multiple parsing options: built-in NTs tt ('modifiers') or 1 other option.
    --> /home/aaron/repos/rust/compiler/rustc_middle/src/query/mod.rs:23:11
     |
12   | / rustc_queries! {
13   | |     query trigger_delay_span_bug(key: DefId) -> () {
14   | |         desc { "trigger a delay span bug" }
15   | |     }
...    |
23   | |     query hir_crate(key: ()) -> &'tcx Crate<'tcx> {
     | |           ^^^^^^^^^
...    |
1715 | |     }
1716 | | }
     | |_- in this expansion of `rustc_query_append!`
     |
    ::: compiler/rustc_query_impl/src/lib.rs:51:1
     |
51   |   rustc_query_append! { [define_queries!][<'tcx>] }
     |   ------------------------------------------------- in this macro invocation

The particular bug shown in this error message will be fixed
in a separate PR.

[rust-highfive]

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

[Aaron1011]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 34f1161 with merge a79bb9d7ed943b0f8fe3fd4c74d833d6ec282050...

[bors]

☀️ Try build successful - checks-actions
Build commit: a79bb9d7ed943b0f8fe3fd4c74d833d6ec282050 (a79bb9d7ed943b0f8fe3fd4c74d833d6ec282050)

[rust-timer]

Queued a79bb9d7ed943b0f8fe3fd4c74d833d6ec282050 with parent a50d721, future comparison URL.

[rust-timer]

Finished benchmarking try commit (a79bb9d7ed943b0f8fe3fd4c74d833d6ec282050): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[bjorn3]

The particular bug shown in this error message will be fixed
in a separate PR.

fb7e483 from #85830 fixed it.

Edit: just saw your a03cf1b from #86119 which fixes it too, but in a different way.

[camelid]

r? @cjgillot

[cjgillot]

@bors r+ rollup

[bors]

📌 Commit 34f1161 has been approved by cjgillot