Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkchecker tool report failed for a non-English heading in a translation of TRPL #89060

Open
thinh9e opened this issue Sep 5, 2021 · 2 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@thinh9e
Copy link

thinh9e commented Sep 5, 2021

URL to the section(s) of the book translation with this problem:
https://rust-lang-vn.github.io/book/ch01-02-hello-world.html

Description of the problem:

I'm translating the section 1.2. Hello, World! into Vietnamese. For the link:

-[troubleshooting]: ch01-01-installation.html#troubleshooting
+[troubleshooting]: ch01-01-installation.html#xử-lý-sự-cố

After I commit, the Actions CI report failed on task Run lints that runs the linkchecker script from this repo:

ch01-02-hello-world.html:222: broken link fragment `#x%E1%BB%AD-l%C3%BD-s%E1%BB%B1-c%E1%BB%91` pointing to `ch01-01-installation.html`
...
Error: Process completed with exit code 1.

I double-checked it manually and confirmed it wasn't a broken link as reported.
I think the linkchecker tool can't compare between raw string #xử-lý-sự-cố and encode string #x%E1%BB%AD-l%C3%BD-s%E1%BB%B1-c%E1%BB%91.
Thanks!

@carols10cents
Copy link
Member

Hi! Please feel free to disable the linkchecker in your translation repo until this is fixed. The linkchecker is actually in the main rust-lang/rust repo, so I'm going to move this issue over there. Thanks!

@carols10cents carols10cents transferred this issue from rust-lang/book Sep 18, 2021
@carols10cents carols10cents changed the title Linkchecker tool report failed for the non-English heading Linkchecker tool report failed for a non-English heading in a translation of TRPL Sep 18, 2021
@carols10cents carols10cents added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc labels Sep 18, 2021
@carols10cents
Copy link
Member

To be clear: we are not currently merging translations into TRPL's repo and shipping them with Rust, so this won't break Rust currently, but we might someday and it'd be nice to have this fixed in general :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

2 participants