Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: inherent impls overlap check #89820

Closed
Mark-Simulacrum opened this issue Oct 12, 2021 · 1 comment · Fixed by #89822
Closed

regression: inherent impls overlap check #89820

Mark-Simulacrum opened this issue Oct 12, 2021 · 1 comment · Fixed by #89822
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

perf.rust-lang.org's stm32f4 is failing:

Checking stm32f4 v0.12.1 (/tmp/.tmprwkENR)
thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', compiler/rustc_typeck/src/coherence/inherent_impls_overlap.rs:242:74
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.57.0-nightly (02f2b31e6 2021-10-12) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z self-profile=/tmp/.tmprwkENR/self-profile-output -C embed-bitcode=no -C debuginfo=2 --crate-type lib

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [crate_inherent_impls_overlap_check] check for overlap between inherent impls defined in this crate
#1 [analysis] running analysis passes on this crate
end of query stack
thread 'main' panicked at 'assertion failed: status.success()', collector/src/rustc-fake.rs:77:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: could not compile `stm32f4`
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. P-high High priority labels Oct 12, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.57.0 milestone Oct 12, 2021
@Mark-Simulacrum
Copy link
Member Author

I suspect this is caused by a3f98a7, merged in #89791 (rollup) and root PR #89643

@cjgillot @rust-lang/wg-traits -- is this expected breakage (i.e., code in stm32f4 is unsound/should never have been accepted)?

@Mark-Simulacrum Mark-Simulacrum added the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Oct 13, 2021
@bors bors closed this as completed in eeb16a2 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant